Skip to content
This repository has been archived by the owner on Oct 31, 2024. It is now read-only.

chore: cleanup feature flags, merge taskmanager #272

Closed
wants to merge 6 commits into from
Closed

chore: cleanup feature flags, merge taskmanager #272

wants to merge 6 commits into from

Conversation

gruberb
Copy link
Contributor

@gruberb gruberb commented Jul 31, 2023 •
edited
Loading

Description

Merging task-manager-futures with the double echo to avoid the additional layer of communication between the two. Also removing the feature flag and adjusting the tests accordingly.

Fixes TP-650

Additions and Changes

  • Removal of the feature flag

PR Checklist:

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added or updated tests that comprehensively prove my change is effective or that my feature works

@gruberb gruberb marked this pull request as ready for review July 31, 2023 13:35
@gruberb gruberb requested a review from a team as a code owner July 31, 2023 13:35
@codecov
Copy link

codecov bot commented Aug 1, 2023 •
edited
Loading

Codecov Report

Merging #272 (f217cf4) into main (de9c221) will decrease coverage by 0.47%.
Report is 1 commits behind head on main.
The diff coverage is 86.25%.

@@            Coverage Diff             @@
##             main     #272      +/-   ##
==========================================
- Coverage   52.80%   52.33%   -0.47%     
==========================================
  Files         207      206       -1     
  Lines        9833     9818      -15     
==========================================
- Hits         5192     5138      -54     
- Misses       4641     4680      +39
Files Changed Coverage Δ
crates/topos-tce-broadcast/src/constant.rs 44.44% <ø> (+4.44%) ⬆️
...s-tce-broadcast/src/double_echo/broadcast_state.rs 83.68% <ø> (-0.23%) ⬇️
crates/topos-tce-broadcast/src/double_echo/task.rs 90.90% <ø> (ø)
crates/topos-tce-broadcast/src/double_echo/mod.rs 73.07% <73.91%> (-9.36%) ⬇️
crates/topos-tce-broadcast/src/lib.rs 87.80% <100.00%> (-1.33%) ⬇️
crates/topos-tce-broadcast/src/tests/mod.rs 100.00% <100.00%> (ø)

... and 3 files with indirect coverage changes

@gruberb gruberb closed this Sep 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Freyskeyd Freyskeyd Awaiting requested review from Freyskeyd Freyskeyd is a code owner automatically assigned from topos-protocol/protocol

@JDawg287 JDawg287 Awaiting requested review from JDawg287 JDawg287 is a code owner automatically assigned from topos-protocol/protocol

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@gruberb